aspnet / LibraryManager

MIT License
457 stars 83 forks source link

File copying errors #753

Closed leotsarev closed 6 months ago

leotsarev commented 6 months ago

Summary of the changes

Some kind of improvement to #697

jimmylewis commented 6 months ago

@leotsarev build failure indicates you missed a reference to the CopyFileAsync method.

leotsarev commented 6 months ago

It's hard to build locally. I can't found most Nugets. I'll look into

jimmylewis commented 6 months ago

It's hard to build locally. I can't found most Nugets. I'll look into

Sounds related to #728, I wonder if you have a different SDK version that to different runtime packages. Can you list your Nuget restore issues there? And maybe the workaround in https://github.com/aspnet/LibraryManager/issues/728#issuecomment-2044389049 can help work around that.

leotsarev commented 6 months ago

I used https://github.com/aspnet/LibraryManager/blob/44c5cb32c2449a81df7ab2b2e4b03ca141eca2d6/nuget.config and was able to build locally

leotsarev commented 4 months ago

@phil-allen-msft may be you will release prerelease version with this change? I'm eager to look into errors...

phil-allen-msft commented 4 months ago

@leotsarev , I believe you will find that 17.11 Preview 2 of Visual Studio has this change. Please let us know what you find.

leotsarev commented 4 months ago

Whats version of CLI tools and nuget package?

leotsarev commented 3 months ago

@phil-allen-msft could I test it using CLI tools / Nuget package ?

leotsarev commented 3 months ago

@phil-allen-msft I don't see this changes in 8.0.401 https://github.com/joinrpg/joinrpg-net/actions/runs/10417533421/job/28851967326