search

aspnet / Logging

[Archived] Common logging abstractions and a few implementations. Project moved to https://github.com/aspnet/Extensions
Apache License 2.0
507 stars 247 forks source link

Making LoggingEventSource public sealed #900

Closed rymeskar closed 6 years ago

rymeskar commented 6 years ago

Fixing #899

dnfclas commented 6 years ago

CLA assistant check
All CLA requirements met.

rymeskar commented 6 years ago

The check failures do not seem to be related to my changes. Unfortunately, I am not able to rerun them without a new commit :(

pakrym commented 6 years ago

Not sure we want to expose Keywords in this manner. I was thinking about moving the enum out of the class and exposing only it.

rymeskar commented 6 years ago

When I read this blog post from 2012. It mentioned that the Keywords must be nested.

But TBH, I am not sure what is the enforcement mechanism or whether that requirement still holds.

pakrym commented 6 years ago

Good point.

Make sure every other member is private/internal then.

pakrym commented 6 years ago

Thank you for your contribution.