search

aspnet / MetaPackages

[Archived] NuGet meta packages. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
211 stars 109 forks source link

Use custom KoreBuild and dotnet-install if specified #214

Closed JunTaoLuo closed 7 years ago

JunTaoLuo commented 7 years ago

This allows me to use a custom dotnet-install that skips the installation of the 1.0.5/1.1.2 runtime on certain platforms during the build on ubuntu.16.10.

JunTaoLuo commented 7 years ago

Test failures are due to an un-updated M.A.Server.IntegrationTesting package see https://github.com/aspnet/Hosting/pull/1161

natemcmaster commented 7 years ago

cc @ryanbrandenburg

FYI - we're also working on further changes to the KoreBuild bootstrapper to enable docker build. (see https://github.com/aspnet/BuildTools/issues/337). If we finish that before https://github.com/aspnet/BuildTools/issues/347, this work would break this solution. I think it would be better to keep the bootstrappers consistent with other repos, and instead add an env variable such as KOREBUILD_SKIP_LEGACY_DOTNET_INSTALL=1 that simply prevents this from running.

JunTaoLuo commented 7 years ago

Agreed, will make use of aspnet/BuildTools#360 instead

JunTaoLuo commented 7 years ago

Merging now to fix the RuntimeStore_Installer builds.

natemcmaster commented 7 years ago

Retroactive :shipit: