search

aspnet / MetaPackages

[Archived] NuGet meta packages. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
211 stars 109 forks source link

Potentially misleading documentation comment for WebHost.CreateDefaultBuilder #223

Closed onyxmaster closed 7 years ago

onyxmaster commented 7 years ago

Hi! The documentation comment mentions that CreateDefaultBuilder(string[] args) "adds the developer exception page when IHostingEnvironment.EnvironmentName is 'Development'". If I understand correctly, this is usually done by Startup.Configure(IApplicationBuilder). I believe this documentation comment should be improved.

JunTaoLuo commented 7 years ago

Good catch. We used to have the developer exception page middleware added by default in a development environment by adding a startup filter but that was removed in https://github.com/aspnet/MetaPackages/pull/95. However, we neglected to update the documentation to reflect the removal.