search

aspnet / MusicStore

[Archived] MusicStore test application that uses ASP.NET/EF Core. Project moved to https://github.com/aspnet/AspNetCore
1.3k stars 878 forks source link

Use proper JavaScript comment. Closes #519 #521

Closed peterblazejewicz closed 9 years ago

peterblazejewicz commented 9 years ago

This commit replaces Razor syntax specific comment with default, line JavaScript comment

I've already signed CLA!

Thanks!

dnfclas commented 9 years ago

Hi @peterblazejewicz, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

dougbu commented 9 years ago

@peterblazejewicz does Atom handle Razor comments any better if they appear outside <script> elements?

peterblazejewicz commented 9 years ago

@dougbu Yes, as expected: 20150804230556

Eilon commented 9 years ago

:shipit: This change is fine, even though it is functionally slightly different from what it was.

dnfclas commented 9 years ago

@peterblazejewicz, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

Eilon commented 9 years ago

@dougbu can you merge and watch the CI?

kichalla commented 9 years ago

I already merged this actually.

Eilon commented 9 years ago

Oh... then close :smile:

kichalla commented 9 years ago

Sure! commit 49b96a7f2f8557face72cf8bd20fadae41145500