aspnet / MusicStore

[Archived] MusicStore test application that uses ASP.NET/EF Core. Project moved to https://github.com/aspnet/AspNetCore
1.3k stars 878 forks source link

Consider Replacing obsolete `hgroup` tag in html code #523

Closed peterblazejewicz closed 7 years ago

peterblazejewicz commented 9 years ago

The code is using obsolete (2 years and counting) hgroup element a lot. Can you consider to replace it with other markup with similar purpose but better fitted to sample code? reasoning: http://www.w3.org/html/wg/drafts/html/master/obsolete.html#non-conforming-features

Examples of transition:

<hgroup>
    <h2>@ViewBag.Title.</h2>
    <h3 class="text-danger">Unsuccessful login with service.</h3>
</hgroup>
<header>
    <h2>@ViewBag.Title.</h2>
    <p class="text-danger">Unsuccessful login with service.</p>
</header>
<hgroup class="title">
    <h1>@ViewBag.Title.</h1>
</hgroup>
<header>
    <h1>@ViewBag.Title.</h1>
</header>
<hgroup>
    <h1 class="text-danger">Locked out.</h1>
    <h2 class="text-danger">This account has been locked out, please try again later.</h2>
</hgroup>
<header>
    <h1 class="text-danger">Locked out.</h1>
    <p class="text-danger">This account has been locked out, please try again later.</p>
</header>

The examples also show how to replace semantically controversial use of h1/h2 and h2/h3 without sections in content with more proper markup.

Thoughts?

peterblazejewicz commented 9 years ago

@Eilon Thanks for those typos!

Eilon commented 9 years ago

Now done :smile:

rustd commented 8 years ago

We should replace hgroup by header and replace h2 by p tag. @peterblazejewicz do you want to send a PR?

peterblazejewicz commented 8 years ago

@rustd Sure, you meant aspnet/templates I'm sure :)