search

aspnet / MusicStore

[Archived] MusicStore test application that uses ASP.NET/EF Core. Project moved to https://github.com/aspnet/AspNetCore
1.3k stars 878 forks source link

Re-enable tests skipped due to CoreFX bug #627

Closed JunTaoLuo closed 8 years ago

JunTaoLuo commented 8 years ago

Revert the changes in https://github.com/aspnet/MusicStore/commit/a3b959a02837fe413987cd513a8d2439d42f05a7 once we have the CoreFX fix for https://github.com/dotnet/corefx/issues/7440

BrennanConroy commented 8 years ago

This can be reverted now

JunTaoLuo commented 8 years ago

Had to redisable these tests in https://github.com/aspnet/MusicStore/pull/659. Reopening this issue to track enabling of these tests after we have an updated cli.

Eilon commented 8 years ago

@JunTaoLuo perhaps we can verify this again today? We should have fairly recent CoreFX's already, and today we've taken an even newer one.

JunTaoLuo commented 8 years ago

@Eilon already doing that. There seems to be another problem, I'm verifying whether that is an issue with CoreFX.

Eilon commented 8 years ago

Thanks!

JunTaoLuo commented 8 years ago

blocked on https://github.com/dotnet/corefx/issues/8941

stephentoub commented 8 years ago

@JunTaoLuo, can you try https://github.com/dotnet/corefx/pull/8946?

JunTaoLuo commented 8 years ago

@stephentoub How do I test out your fix in the linked PR? Will you build a package for me to test?

stephentoub commented 8 years ago

How do I test out your fix in the linked PR?

You can build System.Net.Http.dll from my branch and overwrite the one in your published directory. If you don't want to build it yourself, I've emailed you a build you can use.

JunTaoLuo commented 8 years ago

@stephentoub Thanks, I verified this has fixed the issue we are running into.

JunTaoLuo commented 8 years ago

tests enabled after we received the fixes in https://github.com/dotnet/corefx/pull/9282