Changed CartItem.CartId type from string to Guid. Needed this change…

aspnet / MusicStore

[Archived] MusicStore test application that uses ASP.NET/EF Core. Project moved to https://github.com/aspnet/AspNetCore

1.3k stars 878 forks source link

Changed CartItem.CartId type from string to Guid. Needed this change… #687

Closed martinpf closed 8 years ago

martinpf commented 8 years ago

Changed CartItem.CartId type from string to Guid. Needed this change to ease the creation of an index on the CartId column in the database. String is not an indexable type, guid (uniqueidentifier in SQL Server) is. Adding that index has a big impact on database performance for the MusicStore app for stress and reliability testing

dnfclas commented 8 years ago

Hi @martinpf, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

martinpf commented 8 years ago

decided to commit to another branch