search

aspnet / MusicStore

[Archived] MusicStore test application that uses ASP.NET/EF Core. Project moved to https://github.com/aspnet/AspNetCore
1.3k stars 878 forks source link

Fixed incorrect DNX targets #690

Closed IEvangelist closed 8 years ago

IEvangelist commented 8 years ago

Wrapped IWebHost in a using for the .Run invocation. Fixed incorrect .xproj DNX targets.

dnfclas commented 8 years ago

Hi @IEvangelist, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

Eilon commented 8 years ago

@IEvangelist thanks for the PR! Please see the comment I just left, plus the CLA bot is requesting that you sign the CLA, which is required for us to accept contributions.

dnfclas commented 8 years ago

@IEvangelist, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

dnfclas commented 8 years ago

@IEvangelist, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

IEvangelist commented 8 years ago

Hi @Eilon,

I removed the change for the wrapping of the IWebHost instance in a using. On the aspnet/Templates I had an open issue to make this more consistent - but after further discussion it was closed. I have also signed the CLA.

Thank you

Eilon commented 8 years ago

@IEvangelist thanks!

@kichalla , all yours!

kichalla commented 8 years ago

e0082643168de12b680f98294667bf8c291da416

Thanks! @IEvangelist