search

aspnet / MusicStore

[Archived] MusicStore test application that uses ASP.NET/EF Core. Project moved to https://github.com/aspnet/AspNetCore
1.3k stars 878 forks source link

remove app.json #708

Closed friism closed 7 years ago

friism commented 8 years ago

Please note that, while I originally added this, I'm no longer working at Heroku. I propose that the button be removed since the buildpack is no longer maintained and is based on Mono, not .NET core.

Eilon commented 7 years ago

@friism thanks for the PR, can you sign the CLA so we can accept this? Otherwise we can do it ourselves as well. Thanks!

friism commented 7 years ago

@Eilon I signed the CLA last year

Eilon commented 7 years ago

@friism yeah I figured you did, because we've taken PRs from you before 😄 I think what changed is that at that time (a loooong long time ago) the repos were owned by Microsoft Open Technologies, and now that it's all moved over to .NET Foundation, it's a different CLA (different owner == different CLA).

Would you mind signing the new CLA? I know it's not fun to have to re-sign 😦

friism commented 7 years ago

@Eilon np, getting that signed now

friism commented 7 years ago

@Eilon done

dnfclas commented 7 years ago

@friism, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, DNFBOT;

Eilon commented 7 years ago

@friism thank you! Sorry for the hassle! We'll get this merged ASAP.