search

aspnet / MusicStore

[Archived] MusicStore test application that uses ASP.NET/EF Core. Project moved to https://github.com/aspnet/AspNetCore
1.3k stars 878 forks source link

Fix NuGet.Config name casing #719

Closed mfilippov closed 7 years ago

mfilippov commented 7 years ago

If NuGet.config has an incorrect case, dotnet restore don't use it on a case-sensitive fs.

dnfclas commented 7 years ago

Hi @mfilippov, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

Eilon commented 7 years ago

Hmm, NuGet.config is the case that's used everywhere as far as I can tell. Are you sure this is the wrong case here?

Eilon commented 7 years ago

@yishaigalatzer ?

mfilippov commented 7 years ago

@Eilon This commit helps me restore packages on mac with case-sensitive fs.

Eilon commented 7 years ago

@mfilippov I understand the purpose, I'm just not sure that it is wrong. We build all these repos on Windows, Mac, and Linux, and haven't had any issues.

emgarten commented 7 years ago

NuGet treats OSX as case insensitive and does not check all casings of the file name. I've opened https://github.com/NuGet/Home/issues/4019 to track the issue.

Ideally the NuGet.Config casing should be used every. I recommend taking this PR.

Eilon commented 7 years ago

@emgarten how do our Ubuntu builds work, then? Does NuGet still allow NuGet.config on case-sensitive file systems? Or is it that we should use the "most preferred" name to avoid the fallbacks?

emgarten commented 7 years ago

@Eilon on Ubuntu NuGet will find NuGet.config. For perf reasons NuGet skips the extra file casing checks on OSes that it expects to be case-insensitive, when it does that it checks only for NuGet.Config. There isn't a good way to tell from a managed app if the file system is actually case sensitive or not, but this could be fixed just by always checking for the extra casings on OSX in NuGet.

natemcmaster commented 7 years ago

@mfilippov thanks for the contribution. Sorry this fell off our radar for a while. At this point, the PR is unmergeable because there are file conflicts. I'm closing for now as it appears the underlying issue is already tracked https://github.com/NuGet/Home/issues/4019