search

aspnet / MusicStore

[Archived] MusicStore test application that uses ASP.NET/EF Core. Project moved to https://github.com/aspnet/AspNetCore
1.3k stars 878 forks source link

Support using PostgreSQL as a database (via Npgsql) #730

Closed tmds closed 7 years ago

tmds commented 7 years ago

Fixes https://github.com/aspnet/MusicStore/issues/710

tmds commented 7 years ago

Can I get some feedback on the PR?

Hussain-arif commented 7 years ago

feedback of what type ??????

On Thu, Dec 8, 2016 at 1:21 PM, Tom Deseyn notifications@github.com wrote:

Can I get some feedback on the PR?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/aspnet/MusicStore/pull/730#issuecomment-265681037, or mute the thread https://github.com/notifications/unsubscribe-auth/AT69MSWZJHurhkZXxXzMIURLQk5VYItrks5rF74agaJpZM4LBfC9 .

tmds commented 7 years ago

feedback of what type ??????

Code review to get the PR merged.

tmds commented 7 years ago

@Tratcher can you or someone else have a look please?

Eilon commented 7 years ago

@tmds thanks for sending the PR, however for the time being the MusicStore app here is really just a test app that we use for our end-to-end test automation. As such, we generally don't add anything that won't be used by our automated tests because it increases the cost of maintaining this app.

If you'd like to maintain a separate copy of MusicStore in your own repo that is modified to show alternative options, such as using PostgreSQL, we would be happy to have a link from the readme of this repo to point to that.