search

aspnet / MusicStore

[Archived] MusicStore test application that uses ASP.NET/EF Core. Project moved to https://github.com/aspnet/AspNetCore
1.3k stars 878 forks source link

Upgrade to VS 2017 #734

Closed natemcmaster closed 7 years ago

natemcmaster commented 7 years ago

Part of https://github.com/aspnet/Universe/issues/469. Depends on https://github.com/aspnet/Hosting/pull/913. Includes a few workaround for RC.2 bugs, but should mostly work now.

✅ E2E tests pass. ✅ Launching/debugging MusicStore portable in VS works. ❌ Launching/debugging MusicStore.Standalone in VS fails. cc @mlorbetske

The program '[29116] dotnet.exe' has exited with code -2147450749 (0x80008083).

cc @muratg @Eilon

BrennanConroy commented 7 years ago

With my limited knowledge it looks good 🐑 :it:

natemcmaster commented 7 years ago

Found a blocking issue!

We can't upgrade this project yet because we won't have a way to filter tests based on Xunit trait. We need this to run tests for that are specifically designed for NanoServer. dotnet-test-xunit provided a way to filter on traits, but there is no equivalent in xunit.runner.visualstudio and dotnet-test for MSBuild.

It looks like this issue has been opened many times, but there has been no resolution yet. https://github.com/aspnet/Tooling/issues/182 https://github.com/aspnet/Tooling/issues/684 https://github.com/dotnet/cli/issues/2252 https://github.com/dotnet/cli/issues/3832 https://github.com/xunit/xunit/issues/889

cc @Eilon @blackdwarf

natemcmaster commented 7 years ago

:up: :date: Removing [blocked] label. I've added a workaround for the inability to filter by xunit traits. (see https://github.com/aspnet/MusicStore/pull/734/commits/fe4bb038b92a8934281c75d6737613e6cc4c118e)

Also, discovered that these tests weren't running anyways: https://github.com/aspnet/Testing/issues/244