search

aspnet / MusicStore

[Archived] MusicStore test application that uses ASP.NET/EF Core. Project moved to https://github.com/aspnet/AspNetCore
1.3k stars 878 forks source link

fork RemoveFromCart #745

Closed vmural closed 7 years ago

dnfclas commented 7 years ago

Hi @vmural, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, DNFBOT;

Eilon commented 7 years ago

Hi @vmural can you share more info about this PR?

kimbaudi commented 7 years ago

The "Remove From Cart" UI doesn't work and @vmural is trying to fix it. Currently, the RemoveFromCart method in ShoppingCartController returns a ShoppingCartRemoveViewModel as a JsonResult that has properties which are PascalCase (i.e., Message, CartTotal, CartCount, ItemCount, DeleteId). However, the jQuery ajax call gets the data as camelCase (i.e., message, cartTotal, cartCount, itemCount, deleteId). As a result, removing an item from the cart isn't working correctly.

Looking at @vmural's commit, shows that he is missing '}' which is causing an even bigger error.

I'll try to fork this repo and commit the fix.

Eilon commented 7 years ago

Closing this; we'll look at https://github.com/aspnet/MusicStore/pull/762 instead. Thanks!