Closed kichalla closed 7 years ago
@ajcvickers - can someone on your team take a look at this?
@ajcvickers anything to do here for preview1? Or should we move to preview2?
@Eilon Sent a PR for this 12 days ago. Hasn't been looked at yet. There is no functional change, just a change to be more explicit in configuration so that the warning that configuration is not explicit is not shown. The app will function the same way with or without the warning. So, as far as I am aware, there is no need to do this for any particular release, but also no reason not to do it.
Ah ok let's just fix in 'dev' then, now that we've branched.
@Eilon What's the process for getting a review on the PR? Does anybody own MusicStore?
@kichalla signed off on the PR yesterday. He is Mr. Music Store.
@Eilon Oops. Sorry. Missed that he signed off on it. Thanks!
When E2E tests are run, there are bunch of warnings related to EF. Fix them: