search

aspnet / MusicStore

[Archived] MusicStore test application that uses ASP.NET/EF Core. Project moved to https://github.com/aspnet/AspNetCore
1.3k stars 878 forks source link

FIX docker-compose build error https://github.com/aspnet/MusicStore/issues/794 #795

Closed takekazuomi closed 7 years ago

takekazuomi commented 7 years ago

Fix Issue: https://github.com/aspnet/MusicStore/issues/794

Change overview

  1. Change base image to use dotnet:2.0-sdk-nanoserver.
  2. Copy build/dependencies.props and repo.targets.
  3. Add healthcheck in db.

Relevant Issue/PR

dnfclas commented 7 years ago

@takekazuomi, Thanks for your contribution. To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla2.dotnetfoundation.org.

It will cover your contributions to all .NET Foundation-managed open source projects. Thanks, .NET Foundation Pull Request Bot

dnfclas commented 7 years ago

@takekazuomi, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.
Thanks, .NET Foundation Pull Request Bot

MichaelSimons commented 7 years ago

@natemcmaster - can you take a look and merge if acceptable? Would be nice to get the Docker experience working.

natemcmaster commented 7 years ago

Thanks for trying to solve this. However, after discussing with the team, we've decided to remove Dockerfiles from this repo altogether. We don't use these files in our testing anymore, which is why they are broken and stale.

FYI - this repository is actually meant to be a test application, and isn't really supposed to be a sample or tutorial app. There are a handful of documents on https://docs.asp.net that demonstrate how to use ASP.NET Core with Docker. The source code for our docs is also open source and takes contributions. See https://github.com/aspnet/Docs