search

aspnet / MusicStore

[Archived] MusicStore test application that uses ASP.NET/EF Core. Project moved to https://github.com/aspnet/AspNetCore
1.3k stars 878 forks source link

Re-enable TreatWarningsAsErrors #797

Closed mikeharder closed 7 years ago

mikeharder commented 7 years ago

TreatWarningsAsErrors was temporarily disabled to prevent NuGet warnings from breaking the build. It should be re-enabled once the NuGet warnings are fixed.

Disabled: https://github.com/aspnet/MusicStore/commit/c7fb5763af5c4f9f893a85298bff979b700b4858

mikeharder commented 7 years ago

This is dependent on ingesting a new version of Microsoft.ApplicationInsights. Here's the one remaining warning:

warning NU1603: Microsoft.ApplicationInsights 2.4.0-beta2 depends on System.Diagnostics.DiagnosticSource (>= 4.4.0-beta-25130-03)
but System.Diagnostics.DiagnosticSource 4.4.0-beta-25130-03 was not found. An approximate best match of
System.Diagnostics.DiagnosticSource 4.4.0-preview1-25214-03 was resolved.
mikeharder commented 7 years ago

https://github.com/aspnet/MusicStore/commit/1571dc3d80b9652b34108dffc0d1ec30f67a9e54