search

aspnet / MusicStore

[Archived] MusicStore test application that uses ASP.NET/EF Core. Project moved to https://github.com/aspnet/AspNetCore
1.3k stars 878 forks source link

Set log level. #829

Closed tony-xia closed 6 years ago

tony-xia commented 6 years ago

Set correct log level for WebHost

dnfclas commented 6 years ago

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. Thanks, .NET Foundation Pull Request Bot

Eilon commented 6 years ago

@BrennanConroy can you review & merge?

BrennanConroy commented 6 years ago

You should be using SetMinimumLevel in this scenario

From: Eilon Lipton notifications@github.com Sent: Wednesday, November 8, 2017 4:30:30 PM To: aspnet/MusicStore Cc: Brennan Conroy; Mention Subject: Re: [aspnet/MusicStore] Set log level. (#829)

@BrennanConroyhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fbrennanconroy&data=02%7C01%7Cbrecon%40microsoft.com%7C81c542dca3d04ca772d608d526c60715%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636457554321108252&sdata=3oQo2E9Zxon8SXDBRtGgY6L%2BTYDe4jM5KnUIriMmUNA%3D&reserved=0 can you review & merge?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faspnet%2FMusicStore%2Fpull%2F829%23issuecomment-342873132&data=02%7C01%7Cbrecon%40microsoft.com%7C81c542dca3d04ca772d608d526c60715%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636457554321108252&sdata=o%2Fi%2B5X7Mc1SE6UKTZ7ih1a6uy5v7ptxTWJccmQxSVeo%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAHOVETvTggKF5jT26n5X5hrI1YM-Wqa2ks5s0dclgaJpZM4QKV9e&data=02%7C01%7Cbrecon%40microsoft.com%7C81c542dca3d04ca772d608d526c60715%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636457554321108252&sdata=ubVbozhzdRrnnqKF1jGmXFwR2o4tj08tTSCEkUtocck%3D&reserved=0.

tony-xia commented 6 years ago

Updated, using SetMinimumLevel().

BrennanConroy commented 6 years ago

Thanks for the PR! Looks good @tony-xia