aspnet / Mvc

[Archived] ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
5.62k stars 2.14k forks source link

Remove [Obsolete] action result code #8638

Closed blfuentes closed 5 years ago

blfuentes commented 5 years ago

Related to Open issue:

https://github.com/aspnet/Mvc/issues/6880

Removed obsolete override 'ActionResult.ExecuteResult' methods.

RedirectResult LocalRedirectResult RedirectToActionResult RedirectToPageResult RedirectToRouteResult

dnfclas commented 5 years ago

CLA assistant check
All CLA requirements met.

blfuentes commented 5 years ago

I get no errors while building the solution but it seems this is a breaking change for the tool. ========== Build: 69 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========

How should I proceed?

pranavkm commented 5 years ago

@blfuentes removing these methods may be a bit more involved. We'd most likely create a new baseline for the 3.0 milestone so you wouldn't see the error you're seeing. Thanks for your PR, but I'm going to close this since it's still early for us to figure out how to proceed with 3.0 breaking changes.