React to Razor.Design package removal

aspnet / Mvc

[Archived] ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

5.62k stars 2.14k forks source link

React to Razor.Design package removal #8680

Closed pranavkm closed 5 years ago

pranavkm commented 5 years ago

Remove references to packages (Razor.Design, Razor.Extensions) solely used to bring in compiler \ targets
Target netcoreapp3.0 in samples and tests to allow Sdk to infer values

dougbu commented 5 years ago

@pranavkm it's possible .NET Core changed their default formats between 2.2 and 3.0. Since the failure doesn't occur without your changes, I suspect that's the case. The line to change is https://github.com/aspnet/Mvc/blob/c74a945dda2c96af30bb9dd1482a67edfe6fdd56/test/Microsoft.AspNetCore.Mvc.Core.Test/ModelBinding/RouteValueProviderTests.cs#L78

dougbu commented 5 years ago

@pranavkm I found the relevant CoreFx change: See issue dotnet/corefx#29538, PR dotnet/coreclr#18316 or commit dotnet/coreclr@a51328304a. Their change is in 3.0 only.