Review pubinternal types made public in 3.0

[pranavkm]

As part of https://github.com/aspnet/Mvc/pull/8646, some types that were formerly pubinternal but exposed via public API surface were made public. Review these types. If we land on leaving the types public, add documentation to it.

• Microsoft.AspNetCore.Mvc.Controllers.IControllerPropertyActivator
• Microsoft.AspNetCore.Mvc.Infrastructure.ITypeActivatorCache
• Microsoft.AspNetCore.Mvc.ModelBinding.Validation.ClientValidatorCache
• Microsoft.AspNetCore.Mvc.ModelBinding.Validation.ValidatorCache
• Microsoft.AspNetCore.Mvc.Formatters.MediaTypeSegmentWithQuality
• Microsoft.AspNetCore.Mvc.ModelBinding.PrefixContainer
• Microsoft.AspNetCore.Mvc.ModelBinding.Validation.ValidationStack
• Microsoft.AspNetCore.Mvc.ViewFeatures.Buffers.PagedBufferedTextWriter - Suggested design: https://github.com/aspnet/Mvc/pull/8705/files#r232334070
• Microsoft.AspNetCore.Mvc.ViewFeatures.Buffers.IViewBufferScope
• Microsoft.AspNetCore.Mvc.ViewFeatures.Buffers.ViewBufferValue
• Microsoft.AspNetCore.Mvc.ViewComponents.ViewComponentInvokerCache
• Microsoft.AspNetCore.Mvc.ViewFeatures.ExpressionTextCache
• Microsoft.AspNetCore.Mvc.TagHelpers.CacheTagHelperMemoryCacheFactory
• Microsoft.AspNetCore.Mvc.TagHelpers.GlobbingUrlBuilder

[pranavkm]

Types made internal that are used in OrchardCore (not exhaustive):

• IRazorViewEngineFileProviderAccessor
• CSharpCompiler
• RazorViewCompiler
• MvcRouteHandler
• AttributeRouting

cc @sebastienros

[pranavkm]

Meeting notes

• ControllerFactoryProvider -> internal

• IControllerPropertyActivator -> internal

• DefaultControllerFactory -> internal

• DefaultViewComponentActivator -> internal

• DefaultControllerActivator -> internal

• ITypeActivatorCache -> internal

• DefaultValidationHtmlAttributeProvider, ClientValidatorCache, ValidatorCache -> Follow up design review. User ask for registering their own validation adapters and the answer isn't very clear.

• MediaTypeSegmentWithQuality -> leave as is. ❕ Restart discussion about redoing MediaTypeHeader from HttpAbstractions

• PrefixContainer -> leave as is

• ValidationStack -> consider making it internal if it does not break FluentValidation

• Microsoft.AspNetCore.Mvc.ViewFeatures.Buffers.PagedBufferedTextWriter - Try out suggested design: https://github.com/aspnet/Mvc/pull/8705/files#r232334070

• Microsoft.AspNetCore.Mvc.ViewFeatures.Buffers.IViewBufferScope - Keep public

• Microsoft.AspNetCore.Mvc.ViewFeatures.Buffers.ViewBufferValue - Keep public

• DefaultViewComponentInvoker, ViewComponentInvokerCache -> internal

• class ExpressionHelper
  {
  public string GetExpressionText(LambdaExpression expression);
  public string GetCachedExpressionText(LambdaExpression expression);
  }

  ExpressionMetadataProvider -> public and make it non-static (put it in DI) ExpressionTextCache -> internal

PR to discuss the design

• CacheTagHelperMemoryCacheFactory - public
• GlobbingUrlBuilder - public
• MvcRouteHandler, AttributeRouting -> follow up issue. Needs Design