Move Microsoft.AspNetCore.Mvc.Razor.Internal.RazorInjectAttribute to a non-internal namespace

aspnet / Mvc

[Archived] ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

5.62k stars 2.14k forks source link

Move Microsoft.AspNetCore.Mvc.Razor.Internal.RazorInjectAttribute to a non-internal namespace #8711

Closed pranavkm closed 5 years ago

pranavkm commented 5 years ago

As part of https://github.com/aspnet/Mvc/pull/8706, RazorInjectAttribute was left in the .Internal namespace since it's referenced by Razor codegen. Tracking issue to address this

rynowak commented 5 years ago

Note that this will require https://github.com/aspnet/Razor/issues/2612 to be completed also or VS will show errors for 3.0 apps.

pranavkm commented 5 years ago

Moving this would break RCLs compiled in 2.x that reference the type from the .Internal namespace. Since the attribute appears in code that rzc produced, it would be a poor choice to punish users by moving the type and forcing the RCL to be rebuilt. Closing this.