search

aspnet / Mvc

[Archived] ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
5.62k stars 2.14k forks source link

Provide features required to allow OrchardCore to enable setting up routes correctly #8729

Closed pranavkm closed 5 years ago

pranavkm commented 5 years ago

OrchardCore uses pubinternal types MvcRouteHandler, AttributeRouting : https://github.com/OrchardCMS/OrchardCore/blob/d729a2048a4390380d99e7be9f7968ff8f8e9271/src/OrchardCore/OrchardCore.Mvc.Core/ModularTenantRouteBuilder.cs. Need to come up with a design for for it in 3.0 now that these types are no longer public

pranavkm commented 5 years ago

cc @JamesNK \ @sebastienros

JamesNK commented 5 years ago

Both of those types are related to old routing. Ideally Orchard should start using endpoint routing when it moves to 3.0

sebastienros commented 5 years ago

Can I already do that for 2.2? That something I want to do ASAP, as I need to use LinkGenerator.

JamesNK commented 5 years ago

kind of

Not in an officially supported way. You could define Orchard endpoints in your own data source and register it using DI, and hook up the middleware using pub internal methods, but both of those integration points will change in 3.0, and you'll need to update to use the new mechanisms when upgrading to 3.0.

mkArtakMSFT commented 5 years ago

@sebastienros, @pranavkm should we just delay this untill the required APIs from EndpointRouting are exposed? @JamesNK, will these be available in 3.0.0-preview1 or preview2?

JamesNK commented 5 years ago

Preview 1

sebastienros commented 5 years ago

I don't think we should delay any of these changes, there won't be many opportunity for users to realize what's broken, and for us to change them if necessary.

mkArtakMSFT commented 5 years ago

Well, as the changes are in preview1, there is nothing else to be done here. Closing now. @sebastienros, you'll be able to consume those as soon as preview1 will ship.