Zero cost(ish) diagnositcs when disabled

aspnet / Mvc

[Archived] ASP.NET Core MVC is a model view controller framework for building dynamic web sites with clean separation of concerns, including the merged MVC, Web API, and Web Pages w/ Razor. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

5.62k stars 2.14k forks source link

Zero cost(ish) diagnositcs when disabled #8737

Closed pranavkm closed 5 years ago

pranavkm commented 5 years ago

Inlinable fast-path check if Diagnositcs is enabled

pranavkm commented 5 years ago

Addressing comments from https://github.com/aspnet/Mvc/pull/8349/files. Removed changes to Razor Pages since calls to diagnostics are no longer generated by default. The rest is pretty much the same.

cc @benaadams