search

aspnet / Razor

[Archived] Parser and code generator for CSHTML files used in view pages for MVC web apps. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
883 stars 226 forks source link

Port completion changes to master branch #2658

Closed NTaylorMullen closed 5 years ago

NTaylorMullen commented 5 years ago

All these changes have already gone into release branches. Just bringing them back to master (seems that I hadn't before).

rynowak commented 5 years ago

The code changes here seem fine - keep in mind you will have to update universe.

Is the idea to get this into master and let rel/vs16.0 track our VS work?

NTaylorMullen commented 5 years ago
  • keep in mind you will have to update universe.

ya this is an interesting thing because Universe is archived. @natemcmaster what should i do?

Is the idea to get this into master and let rel/vs16.0 track our VS work?

yes, I'm just trying to ensure that any work that's done in VS branches doesn't get forgotten.

natemcmaster commented 5 years ago

aspnet/AspNetCore is the replacement for aspnet/Universe. Do the same thing there you would have done in aspnet/Universe.

rynowak commented 5 years ago

Ok this seems good then!

NTaylorMullen commented 5 years ago

aspnet/AspNetCore is the replacement for aspnet/Universe. Do the same thing there you would have done in aspnet/Universe.

Done: https://github.com/aspnet/AspNetCore/pull/3683