Hardcode two constants from Microsoft.VisualStudio.ImageCatalog.dll

aspnet / Razor

[Archived] Parser and code generator for CSHTML files used in view pages for MVC web apps. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

883 stars 226 forks source link

Hardcode two constants from Microsoft.VisualStudio.ImageCatalog.dll #2732

Closed KirillOsenkov closed 5 years ago

KirillOsenkov commented 5 years ago

This removes the runtime reference to ImageCatalog which is not available on VS for Mac.

NTaylorMullen commented 5 years ago

This isn't an issue in our current snapping of vsmac8.0 but will be an issue when we update.

rynowak commented 5 years ago

Is there a potential future problem that VS packages will pull in ImageCatalog but it isn't present in VS 4 Mac? I don't think we can realistically avoid referencing it, even though that seems like the right long term solution.

KirillOsenkov commented 5 years ago

I think the editor team came up with an agreed-upon cross-plat equivalent of an ImageMoniker. @amadeusw may know more.

rynowak commented 5 years ago

Merging this since it seems to have no real drawback.