aspnet / Razor

[Archived] Parser and code generator for CSHTML files used in view pages for MVC web apps. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

883 stars 226 forks source link

Only add DotNetCoreRazorConfiguration capability in SDK for netcoreapp3.0. #2752

Closed NTaylorMullen closed 5 years ago

NTaylorMullen commented 5 years ago

Prior to this we were unconditionally adding the DotNetCoreRazorConfiguration capability resulting in 1.0 projects looking like 2.1+ projects.

2751

/cc @pranavkm

NTaylorMullen commented 5 years ago

🆙 📅 Had to add a 1.1 project to verify this doesn't break again. Also added a test to validate that we maintain our expected project capabilities in 3.0.

NTaylorMullen commented 5 years ago

@pranavkm @rynowak is this good? It's blocking the WTE team who have 1.1 tests. If it's good i'll port to aspnetcore-tooling and merge.

NTaylorMullen commented 5 years ago

Closing in favor of https://github.com/aspnet/AspNetCore-Tooling/pull/9