search

aspnet / RoslynCodeDomProvider

Roslyn CodeDOM provider
MIT License
84 stars 43 forks source link

Fixed MSBuild 17.7 issue. #155

Open AraHaan opened 1 year ago

AraHaan commented 1 year ago

This should fix an issue with newer versions of msbuid for both .NET SDK style and non-SDK style projects all in one.

Fixes #154.

AraHaan commented 1 year ago

cc: @StephenMolloy

danpetitt commented 1 year ago

Any chance getting this merged and a new version released?

robmaas commented 1 year ago

The warnings this is causing are breaking our CI builds, can we merge this and release a new version please?

fiseni commented 1 year ago

Looking forward this to being merged.

AraHaan commented 1 year ago

If you guys are also interested I also opened a pull request for shipping this package with roslyn 4.7 which is more updated and modern version of roslyn with updated c# language versions support as well.

rainersigwald commented 1 year ago

The warnings this is causing are breaking our CI builds, can we merge this and release a new version please?

Can you please elaborate on this? The new MSBuild message isn't a warning, it's a message. How is it breaking your CI?

AraHaan commented 1 year ago

The warnings this is causing are breaking our CI builds, can we merge this and release a new version please?

Can you please elaborate on this? The new MSBuild message isn't a warning, it's a message. How is it breaking your CI?

It is breaking it because it helps point out that msbuild was unable to copy the files at all for the reason that the message pointed out.

The lack of the compiler files themselves is what is breaking which ironically fixes itself when the changes in this patch is applied.

robmaas commented 1 year ago

Can you please elaborate on this? The new MSBuild message isn't a warning, it's a message. How is it breaking your CI?

When this issue started it also showed as building warnings in our build in Hosted Azure DevOps agents. Since we have a no-tolerance process it broke our deployment process. At the moment those warnings no longer show up in the pipelines, not sure what changed but they definitely did before.

AraHaan commented 1 year ago

Can you please elaborate on this? The new MSBuild message isn't a warning, it's a message. How is it breaking your CI?

When this issue started it also showed as building warnings in our build in Hosted Azure DevOps agents. Since we have a no-tolerance process it broke our deployment process. At the moment those warnings no longer show up in the pipelines, not sure what changed but they definitely did before.

Also since then has the roslyn binaries vanished from deployments as well in the agents?