Fix Routing's misuse of PathString

aspnet / Routing

[Archived] Middleware for routing requests to application logic. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

272 stars 122 forks source link

Closed rynowak closed 5 years ago

rynowak commented 5 years ago

PathString is meant to be used with unencoded text. So in our case, we should only be responsible for encoding slashes we don't want to roundtrip.

This is working fine in 2.2 but it's inefficient so I'm targeting this at 3.0

rynowak commented 5 years ago

I also expect a nasty reaction PR from MVC 😢 - I think this pattern with TestEncoder was used in lots of places in MVC.

rynowak commented 5 years ago

@natemcmaster - this will require cross-repo testing. Since this isn't urgent I'm going to pick this up after the Razor and MVC repos get merged.

natemcmaster commented 5 years ago

Thanks for the heads up.

natemcmaster commented 5 years ago

Closing as this repo is merging to aspnet/AspNetCore today.