RouteValuesAddressScheme issue

aspnet / Routing

[Archived] Middleware for routing requests to application logic. Project moved to https://github.com/aspnet/AspNetCore

Apache License 2.0

272 stars 122 forks source link

RouteValuesAddressScheme issue #906

Closed JamesNK closed 5 years ago

JamesNK commented 5 years ago

RouteValuesAddressScheme will match endpoints that don't have RouteValuesAddressMetadata metadata. Seems like a bug to me.

From investigating https://github.com/aspnet/Mvc/issues/8690

JamesNK commented 5 years ago

This bug is present in 2.2 but because every Endpoint created by MVC has RouteValuesAddressMetadata it should not effect anyone. To run into this issue they would need to do something unsupported in 2.2 and register their own endpoint data sources.

// @mkArtakMSFT @Eilon @rynowak

rynowak commented 5 years ago

Oh that's bad 😢

Eilon commented 5 years ago

@rynowak bad enough to take in 2.2?

Eilon commented 5 years ago

Oh sorry I missed the email where you said it was OK to go into 3.0.