search

aspnet / Security

[Archived] Middleware for security and authorization of web apps. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
1.27k stars 600 forks source link

Test failure: ChallengeRedirectIsIssuedCorrectly #1875

Closed aspnet-hello closed 5 years ago

aspnet-hello commented 5 years ago

This issue was made automatically. If there is a problem contact ryanbrandenburg.

This test failed with the following error:

The redirect uri is not valid.
https://login.microsoftonline.com/common/oauth2/authorize?client_id=Test%20Id&redirect_uri=https%3A%2F%2Fexample.com%2Fsignin-oidc&response_type=id_token&scope=openid%20profile&response_mode=form_post&nonce=636748777266645870.MGYxYzJmODctMTQ3Ny00OGJkLWIxNDYtMzM1MTI2ZjFiMTRmMjA2MThkOTAtZGY1OC00ZDcyLWEzMjYtOGQ1NDY0NTMyMjk5&state=CfDJ8NOdSWsmhQpKgJsrWkOpNWmBdcel2lDp6l4ieYm3gRq153RYqt5lVWtFYXfMqD4qcZOUXov2uCL_iL02ajxnUsIjxZvoF4HKHHwKJRmfFvCvRtINMXseCeQlQsAo9_IMD97Cv99rKLiNC_1PI15srOgkGMpJzsbiD0T723v8duDe0xKPE7f9WAhKfra-XjhPBbAcs7q4t68vt-Vabi6oAerC6RAMeimjQ0W8XjsNgQPOHEnVe6tX-xOTeVCMjPztwxbFQNtl_LFYI2qKRVvjji2ISjMzl9t1gxR0hCCcX4O_c-SP9Ym7YSDjotPExv_C529OQT_E5-43j89WctLPFkw&x-client-SKU=ID_NETSTANDARD2_0&x-client-ver=5.3.0.0
Parameter x-client-SKU's expected value is 'ID_NETSTANDARD1_4' but its actual value is 'ID_NETSTANDARD2_0'
Expected: True
Actual:   False
   at Microsoft.AspNetCore.Authentication.Test.OpenIdConnect.TestSettings.ValidateRedirectCore(Uri redirectUri, OpenIdConnectRequestType requestType, String[] parametersToValidate) in /_/test/Microsoft.AspNetCore.Authentication.Test/OpenIdConnect/TestSettings.cs:line 163
   at Microsoft.AspNetCore.Authentication.Test.OpenIdConnect.TestSettings.ValidateChallengeRedirect(Uri redirectUri, String[] parametersToValidate) in /_/test/Microsoft.AspNetCore.Authentication.Test/OpenIdConnect/TestSettings.cs:line 128
   at Microsoft.AspNetCore.Authentication.Test.OpenIdConnect.OpenIdConnectChallengeTests.ChallengeRedirectIsIssuedCorrectly() in /_/test/Microsoft.AspNetCore.Authentication.Test/OpenIdConnect/OpenIdConnectChallengeTests.cs:line 40
--- End of stack trace from previous location where exception was thrown ---

Other tests within that build may have failed with a similar message, but they are not listed here. Check the link above for more info.

This test failed on 2.2.

CC @Eilon (because the bot doesn't know who else to pick)

aspnet-hello commented 5 years ago

This comment was made automatically. If there is a problem contact ryanbrandenburg.

Please use this workflow to address this flaky test issue, including checking applicable checkboxes and filling in the applicable "TODO" entries:

aspnet-hello commented 5 years ago

This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 1 failures with about the same error on 2.2 at 10:17:09 AM:

There were 2 failures with about the same error on master at 12:14:23 PM:

There were 2 failures with about the same error on master at 12:19:57 PM:

There were 2 failures with about the same error on master at 11:39:34 AM:

There were 2 failures with about the same error on master at 1:25:59 PM:

There were 2 failures with about the same error on master at 11:51:38 AM:

There were 2 failures with about the same error on master at 11:50:13 AM:

There were 2 failures with about the same error on master at 11:57:00 AM:

There were 2 failures with about the same error on master at 1:40:25 PM:

There were 2 failures with about the same error on master at 2:10:40 PM:

Eilon commented 5 years ago

@Tratcher can you take a look?

Tratcher commented 5 years ago

We need to react to https://github.com/aspnet/Universe/commit/06e9531d50f80d834decdf2a6696df4618bfcba5, or at least make the test less strict about these fields.

@HaoK FYI

aspnet-hello commented 5 years ago

This comment was made automatically. If there is a problem contact ryanbrandenburg.

There were 2 failures with about the same error on master at 2:33:08 PM:

There were 2 failures with about the same error on master at 2:33:07 PM:

There were 2 failures with about the same error on master at 2:31:34 PM:

There were 2 failures with about the same error on master at 2:45:17 PM:

There were 2 failures with about the same error on master at 11:19:38 PM:

There were 2 failures with about the same error on master at 11:15:24 PM:

There were 2 failures with about the same error on master at 11:15:23 PM:

There were 2 failures with about the same error on master at 11:15:17 PM:

There were 2 failures with about the same error on master at 11:15:24 PM:

There were 2 failures with about the same error on master at 11:15:24 PM:

There were 2 failures with about the same error on master at 11:15:24 PM:

There were 2 failures with about the same error on master at 1:07:41 AM:

There were 2 failures with about the same error on 2.2 at 11:24:35 AM:

Eilon commented 5 years ago

@Tratcher does your fix address the 2 more recent failures?

Eilon commented 5 years ago

Oh sorry just realized they're the same. So hopefully yes 😄