Closed benmccallum closed 5 years ago
Sure, do you want to submit a PR for this change?
Sure thing. Any preference on a new param name?
How about "possibleValues", or "permittedValues"? just "values" seems vague, but "anyOfTheseValues" sounds too informal to me.
acceptedValues maybe?
How about valuesAllowed? Or along the lines of auth, valuesAuthorized?
allowedValues is fine
PR up with allowedValues. Cheers!
Merged into master for 3.0, thanks @benmccallum !
"requiredValues" is a confusing name as the method in reality only checks for the presence of one of these values, not all. The parameter description is perfect, but I'm not sure if that's enough. I certainly got confused until I confirmed it in the docs/saw comment.
It's a petty thing I know, but maybe something more generic like "values" would suffice? Or go super explicit like "anyOfTheseValues"?