search

aspnet / ServerTests

[Archived] Tests for Helios, WebListener and Kestrel. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
21 stars 13 forks source link

Skip ANCM v2 in-proc chunked tests #111

Closed mikeharder closed 6 years ago

mikeharder commented 6 years ago
mikeharder commented 6 years ago

@muratg: Do I need any further approval before merging to dev? I'm not sure if we branched for 2.1 yet, so this might need ask mode approval.

muratg commented 6 years ago

I wouldn't think so, but just in case: @pranavkm any objections to take this one?

It's just skipping tests for stuff we won't ship so it should be safe.

mikeharder commented 6 years ago

@muratg: Dev is now open for this repo, so I will merge to dev once AppVeyor passes. Do you think this should be ported to 2.1?

muratg commented 6 years ago

Sounds good for dev. I'm going to leave it up to @ryanbrandenburg to decide if he wants this in Release/2.1.

jkotalik commented 6 years ago

I noticed this failed on Friday; didn’t have time to disable the test. Will investigate when I am back.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Mike Harder notifications@github.com Sent: Tuesday, April 17, 2018 10:42:26 AM To: aspnet/ServerTests Cc: Justin Kotalik; Review requested Subject: Re: [aspnet/ServerTests] Skip ANCM v2 in-proc chunked tests (#111)

Dev is now open for this repo, so I will merge to dev once AppVeyor passes. I'm not sure if this will need to be ported to 2.1.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Faspnet%2FServerTests%2Fpull%2F111%23issuecomment-381802694&data=02%7C01%7CJustin.Kotalik%40microsoft.com%7C57a12470c40a420b084508d5a40479cf%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636595261488924070&sdata=0XpBPDcf%2FZ9H%2FQjeI6CgDzulsc6SueKh3YkHc4jbL4o%3D&reserved=0, or mute the threadhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAH6uFaROM3XNDlWes8D-vaJUKAycjJvtks5tpUiCgaJpZM4TXf4S&data=02%7C01%7CJustin.Kotalik%40microsoft.com%7C57a12470c40a420b084508d5a40479cf%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636595261488924070&sdata=630FGsh2cNAu9%2FSGGgySGBkw3uolCNt6%2F9fhpMYIXoM%3D&reserved=0.