search

aspnet / Session

[Archived] Session state middleware for ASP.NET Core. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
126 stars 66 forks source link

Fix issue#130 #199

Closed hishamco closed 6 years ago

hishamco commented 7 years ago

@Rick-Anderson I added this based on your suggestion before on #130, nothing but I comment the lines, because it's not needed unless someone want to you the SQL Server

aspnet-hello commented 6 years ago

This issue was moved to aspnet/Home#2397

aspnet-hello commented 6 years ago

Sorry I was a bad bot. Re-opening this PR.

Eilon commented 6 years ago

@muratg - any further action planned on this PR?

muratg commented 6 years ago

@Tratcher could you take a look when you have a little bit of time?

muratg commented 6 years ago

@Tratcher could you take another look? Let's either move it forward or close it.

hishamco commented 6 years ago

@muratg I updated the PR to avoid the conflict. Waiting for @Tratcher review, so either you take it or break it 📆 ⌚️

Tratcher commented 6 years ago

The config changes are fine, but AddDistributedMemoryCache should still be the default and AddSqlServerCache should remain commented out.

Tratcher commented 6 years ago

Thanks.