search

aspnet / SignalR-samples

Samples for ASP.NET Core SignalR
751 stars 398 forks source link

Could you update to preview2? #22

Closed kevin-jing closed 6 years ago

kevin-jing commented 6 years ago

ChatSample works, but if I update Microsoft.AspNetCore.All from preview1 to preview2, it doesn't work. So, could you provide an example using preview2?

mikaelm12 commented 6 years ago

Hey @kevin-jing The chat sample is now updated to to preview 2. Just to give you a heads up on what I had to change to update it. I had to update both the client side version from NPM to preview2 and the server side package from nuget to preview2. We also renamed the aspnetcore.signalr.sockets project so I had to fix that reference as well.

Hope this helps!

mikaelm12 commented 6 years ago

The start logic was also simplified since transport fallback is built into start in preview2 but that's not a breaking change

mikaelm12 commented 6 years ago

Done in: d154f53e741b98fac5d5bf000c60bbbd90061a6d