DefaultFilesMiddleware in conjunction with EmbeddedFileProvider and subpaths

[avanderhoorn]

The behaviour of DefaultFilesMiddleware doesn't seem quite right when used in conjunction with EmbeddedFileProvider and subpaths. Specifically if my url was "localhost:3000/static/client/" and my EmbeddedFileProviders baseNamespace was setup to point to static, I would expect that translate through to and look for "localhost:3000/static/client/index.html"... this is not the case however.

Specifically, in scenarios where the EmbeddedFileProvider has been setup as described, the DefaultFilesMiddleware fails to find a match as the subpath.Value (in the first link below below) is equal to /client/ which causes the EmbeddedFileProvider to short circuit (in the second link below):

• https://github.com/aspnet/StaticFiles/blob/dev/src/Microsoft.AspNetCore.StaticFiles/DefaultFilesMiddleware.cs#L69
• https://github.com/aspnet/FileSystem/blob/dev/src/Microsoft.Extensions.FileProviders.Embedded/EmbeddedFileProvider.cs#L151-L154

Based on the comment in GetDirectoryContents, I understand why this is the case - // Non-hierarchal. but in the context of how this is used within DefaultFilesMiddleware it seems like the wrong decision, or at the very least, very limiting - as the way the logic is setup, it can only ever support matching defaults at the root level.

I can think of a few different solutions to this problem, but before putting further energy into this, I wanted to see if there is any desire to support this use case?

[Tratcher]

Yes, this is a known limitation of EmbeddedFileProvider and that's where any enhancements would need to be made.

[avanderhoorn]

I'm happy to bring this up there, but before putting further energy into this, I wanted to see if there is any desire to support this use case?

[Tratcher]

It has come up before, though I can't find the thread at the moment. Yes, it would be nice to make it work eventually.

[muratg]

This issue was moved to aspnet/FileSystem#255