search

aspnet / StaticFiles

[Archived] Middleware for handling requests for file system resources including files and directories. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
114 stars 72 forks source link

Some minor cleanups #251

Closed SimonCropp closed 6 years ago

SimonCropp commented 6 years ago

Feel free to cherry pick any. or let me know if u want isolated PRs for any of them

SimonCropp commented 6 years ago

thoughts on suppressing CS1573?

if we r just going to have dozens of /// <param name="app"></param>, we r essentially ignoring it anyway

/Users/travis/build/aspnet/StaticFiles/src/Microsoft.AspNetCore.StaticFiles/StaticFileExtensions.cs(33,83): 
error CS1573: Parameter 'app' has no matching param tag in the XML comment for 'StaticFileExtensions.UseStaticFiles(IApplicationBuilder, string)' (but other parameters do) [/Users/travis/build/aspnet/StaticFiles/src/Microsoft.AspNetCore.StaticFiles/Microsoft.AspNetCore.StaticFiles.csproj]
Tratcher commented 6 years ago

We'd rather fill it in with something simple than suppress the warning.

Tratcher commented 6 years ago

FYI: we're currently developing in the release/2.2 branch.

SimonCropp commented 6 years ago

ok i will submit a new PR targeting 2.2

SimonCropp commented 6 years ago

We'd rather fill it in with something simple than suppress the warning.

i would too. but in the current context of cleaning up some minor stuff. it would seem omitting the xml doc noise and suppressing the warning should be acceptable.