aspnet / Templates

This repo is OBSOLETE - please see the README file for information
Other
150 stars 57 forks source link

Update template's usage of Entity Framework tools #590

Closed natemcmaster closed 8 years ago

natemcmaster commented 8 years ago

Cref https://github.com/aspnet/EntityFramework/pull/5635. This is in for preview 2.

For preview 2 and beyond, we will be instructing users to put "Microsoft.EntityFrameworkCore.Tools" in the "tools" section of project.json, and "Microsoft.EntityFrameworkCore.Design" into "dependencies".

cc @phenning

dnfclas commented 8 years ago

Hi @natemcmaster, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

phenning commented 8 years ago

One additional comment inline about using __AspNetCorePackageVersion__, looks good.

We should hold off merging until we get a coherence-signed build with the package rename.

natemcmaster commented 8 years ago

@phenning I've updated with the changes and also removed imports from EF.Tools as they won't be necessary anymore.

:watch: will wait on a coherence-signed build with the changes from https://github.com/aspnet/EntityFramework/pull/5689