search

aspnet / Templates

This repo is OBSOLETE - please see the README file for information
Other
150 stars 57 forks source link

Remove unnecessary `imports` from project.json files #613

Closed dougbu closed 8 years ago

dougbu commented 8 years ago

The templates still contain imports required only for earlier Json.NET releases.

@javiercn has cleaned up all of the runtime repos to remove these. But they remain in our templates.

This should be a candidate for the Preview 2 release.

phenning commented 8 years ago

It looks like we still need: "portable-net45+win8" in the Individual Auth template due to Scaffolding due to Microsoft.Composition, this is needed both in the tool and at the project level.

We also still need all the imports for the BundleMinifier tool as well.

We can remove all the other imports from every other tool.

@Eilon, @DamianEdwards Given this, do we want to keep the portable import at the project level for all templates for consistency.

javiercn commented 8 years ago

We have a bug for tracking Microsoft.Composition @pranavkm can you post it here for reference? I believe you filed it.

Eilon commented 8 years ago

My guess is that @DamianEdwards / @davidfowl would want to remove all unnecessary imports, but I'm not certain.

pranavkm commented 8 years ago

Microsoft.Composition work item: https://github.com/dotnet/corefx/issues/6598

phenning commented 8 years ago

N/A for msbuild based projects