search

aspnet / Templates

This repo is OBSOLETE - please see the README file for information
Other
150 stars 57 forks source link

Remove DnxInvisibleContent Bower artifact references #632

Closed scottaddie closed 7 years ago

scottaddie commented 8 years ago

The "EmptyWeb" template's XPROJ file contains references to the following 2 Bower files:

  1. bower.json
  2. .bowerrc

Since neither of these files is included in the template, it's probably best to remove them from the DnxInvisibleContent item group altogether. I would expect a "bare bones" project which makes no assumptions with regard to a client-side package manager when I choose the empty project template.

dnfclas commented 8 years ago

Hi @scottaddie, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

phenning commented 8 years ago

We actually left these in here intentionally for the empty template because we have the item template which adds them and there is no tooling to add this back to the xproj if those item templates are used.

scottaddie commented 8 years ago

@phenning Are there plans to add tooling for this? After all, that's the value Visual Studio adds. If I have to manually edit a project file for a common task such as this, then Visual Studio has failed me.

phenning commented 8 years ago

I'm not aware of any current plans. However, future releases are still being planned. Let's hold off on this PR until the roadmap is complete. It may be that we won't need the InvisibleContent item group in the future.