search

aspnet / Templates

This repo is OBSOLETE - please see the README file for information
Other
151 stars 57 forks source link

Update globbing patterns and use SDK attribute #731

Closed mlorbetske closed 7 years ago

mlorbetske commented 7 years ago

@phenning @seancpeters @davidfowl

dnfclas commented 7 years ago

Hi @mlorbetske, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

davidfowl commented 7 years ago

Is the SDK thing just in prep for that change? Because it's incomplete, the props and targets are supposed to be gone as a result of the SDK node being there. Also the fact that the web templates globbing patterns got crazy makes me sad.

mlorbetske commented 7 years ago

I'll remove the extra props & targets, sending you mail on what we're thinking post this upcoming release

phenning commented 7 years ago

It looks like the removal of the Sdk.Web PackageReference isn't there for StarterWeb.csproj. Both WebAPI and Empty do show this as removed.

phenning commented 7 years ago

Looks good :shipit:

phenning commented 7 years ago

Other then this being really ugly, assuming it addresses the perf concerns, looks good from a template perspective.

:shipit:

mlorbetske commented 7 years ago

@phenning ugly in a way we can change? Yes, that's to fix the perf issues

mlorbetske commented 7 years ago

Merging this to unblock broader testing, will submit another PR if needed

davidfowl commented 7 years ago

@mlorbetske Do you know why the Reference items are needed for .NET Framework?