search

aspnet / Templates

This repo is OBSOLETE - please see the README file for information
Other
150 stars 57 forks source link

1.1 Updates #785

Closed phenning closed 7 years ago

phenning commented 7 years ago

@joeloff @pranavkm @mlorbetske

Razor Precompilation package + other updates.

phenning commented 7 years ago

Do we also want this for WebAPI?

@DamianEdwards

bricelam commented 7 years ago

Nit: Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.SqlServer.Design & Microsoft.EntityFrameworkCore.Tools should have PrivateAssets="All" so they don't get published.

pranavkm commented 7 years ago

Nit: Microsoft.EntityFrameworkCore.Design, Microsoft.EntityFrameworkCore.SqlServer.Design & Microsoft.EntityFrameworkCore.Tools should have PrivateAssets="All" so they don't get published.

Oh right. That's true for Microsoft.AspNetCore.Mvc.Razor.ViewCompilation too.

bricelam commented 7 years ago

Oh wait, this isn't an MSBuild file... 😁 Ignore that if it doesn't make sense here.

phenning commented 7 years ago

We should actually add PrivateAsset in this case. I'll need to update the rules engine to support it. Will update PR.