search

aspnet / Templating

[Archived] ASP.NET Core templates for .NET CLI and Visual Studio. Project moved to https://github.com/aspnet/AspNetCore
Apache License 2.0
205 stars 79 forks source link

/Properties/launchSettings.json should be removed from .gitignore in template content files #760

Closed kasajian closed 6 years ago

kasajian commented 6 years ago

The following files should be updated and /Properties/launchSettings.json should be removed:

    Templating/src/Microsoft.DotNet.Web.Spa.ProjectTemplates/content/React-CSharp/.gitignore
    Templating/src/Microsoft.DotNet.Web.Spa.ProjectTemplates/content/Angular-CSharp/.gitignore
    Templating/src/Microsoft.DotNet.Web.Spa.ProjectTemplates/content/ReactRedux-CSharp/.gitignore

The justification is described here: https://github.com/github/VisualStudio/issues/1405

And here's the actual change made to "VisualStudio.gitignore" @ https://github.com/github/gitignore https://github.com/github/gitignore/pull/2705

mkArtakMSFT commented 6 years ago

Thanks for contacting us, @kasajian. @ryanbrandenburg, can you please look innto this? Thanks!

ryanbrandenburg commented 6 years ago

It seems reasonable to remove this file from the .gitignore. @SteveSandersonMS (who copied the .gitignore over from JavaScriptServices) can you come up with any reason we should keep ignoring launchSettings.json?

SteveSandersonMS commented 6 years ago

@ryanbrandenburg I agree. These SPA templates should be the same as our other ASP.NET Core templates in terms of whether launchSettings.json is gitignored or not.