aspnet / Tooling

Issue tracker and info on Visual Studio tooling for ASP.NET
Other
258 stars 124 forks source link

Is no more Application Insight local SDK a thing ? #1019

Closed Bartmax closed 7 years ago

Bartmax commented 7 years ago

So no more local SDK only, is this now an azure-only service ?

If it's not, then the UI on 2017 is really crafted by evil azure $ eaters. (just kidding, no offense intended)

Also the docs points to the old UI, showing an option not available on 2017. pasted image at 2017_03_16 10_22 am

As an Azure customer that uses app insights already, can you please clarify the situation and if there's a change on how this services is/was used/consumed, can you point to the announcement about it?

Thanks.

mlorbetske commented 7 years ago

This issue was moved to Microsoft/ApplicationInsights-Home#114

gardnerjr commented 7 years ago

@Bartmax where are you not seeing this in 2017? If you created an asp.net or asp.net core project in VS2017, the asp.net tooling already includes AI in local only mode right from project creation.

so this link doesn't appear in the configure window, because AI is already in local mode in those projects. The link only appears if you're adding AI to a completely clean project that doesn't already have AI in it.

If this is not what you're seeing, let me know.

gardnerjr commented 7 years ago

To see the link in 2017, create a new asp.net or asp.net core project, and remove the references to AI (in core, open the csproj and remove the PackageReference for Application Insights. Right click the project, and the Application Insights submenu will be gone. right click the project and do either add->connected service and pick application insights, or right click add->application insights to see the same configure window as above, with the link at the bottom: local only in 2017

Bartmax commented 7 years ago

I see. Now understand what's going on, thank you for detailed explanation. Removing the nuget package enabled the local-only mode option.

My suggestion for improvement: include the link either it's installed or not (or at least tell the user something).

When I go to:

Create new Asp net core web application. Empty. Go to connected services It doesn't say that it's already "connected" So when you try to connect, you get this:

image

image

image

From that UI what I see is, that even the SDK has been added, it looks like the process is incomplete until you connect to azure. very misleading imho.

Thanks for the clarification. Greatly appreciated.

gardnerjr commented 7 years ago

At one point in the past, that green bar at the top was a more standard looking green checkbox, and the red rectangle was an open circle, like this:

old configwindow

in this form, all of the "completed" steps were more obvious checkboxes, and all the "optional" things were open circles. would this make it more obvious?

Yes, we don't consider your configuration it complete until you connect to azure, as without that, you aren't doing any real kind of telemetry, you're doing local diagnostics type work, since nothing ever gets stored. But just because it isn't complete doesn't mean that it is nonfunctional.