search

aspnet / WebHooks

[Archived] Libraries to create and consume web hooks on ASP.NET Core. Project moved to https://github.com/aspnet/AspLabs
Apache License 2.0
627 stars 439 forks source link

Multiple hooks error #148

Closed Nostreum closed 7 years ago

Nostreum commented 7 years ago

Hi !

I've created a WebHook controllers for an internal instance of Gitlab, everything is working locally. I just deployed it to an IIS and i've a weird issue : Same hooks are received multiple times. For example if i do the following actions :

On my computer i receive 2 hooks (1 issue and 1 comment) and on IIS i receive 3 hooks (1 issue then 1 issue and 1 comment). It's like hooks are "saved" somewhere and got "re-called" with the next Hook. If someone has a idea...

Thank's.

garora commented 7 years ago

@Nostreum - Have your written any custom code for it? I did the same and I am receiving same on local and on IIS. I used sample code.

Nostreum commented 7 years ago

@garora No the code is exactly the same... Apparently, sometimes IIS takes too long to answer, so gitlab decide that the hook failed and retry it. Locally it takes between 250 and 350 ms, and 900-1100 on IIS. I've build a temporally solution (saving hook's id), but I don't know how to resolve this properly.

garora commented 7 years ago

@Nostreum - Its really a weird issue. Are there any specific steps so that I can recreate this issue at my end. I tried the same code on a new box and that is working as a charm.

Nostreum commented 7 years ago

@garora I've configured an HTTPS site, without any specific steps... To be sure i just created an other one and i get the same issue. I've done more tests. When i press the "Test" button on gitlab (to send a hook), my endpoint receive it 11-12 seconds later :

I tried to send a POST request with postman, and i got the same problem : postman

I don't know a lot of thing about IIS so maybe something happen here, like a "queue" or something..

garora commented 7 years ago

I did try locally and over my private Git not sure if your issue is related Gitlab. @HenrikFrystykNielsen would give the insight on this.

Nostreum commented 7 years ago

I found the problem : My site become "off" on IIS, so when i send a new hook, it takes some time to restart. But, the site go off after like 20-30 secs of inactivity. I tried some solutions but nothing work (AlwaysRunning mode, disabled idle-timeout etc), if you have an idea ..

Nostreum commented 7 years ago

Well, i solve my problem... My log file was in the bin folder, each time i modify it, the bin folder changed, and my application was recycled. This is why for each hook my site needed to restart...

garora commented 7 years ago

@Nostreum - great you find the solution for your problem.