Closed dougbu closed 6 years ago
@dougbu, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request. Thanks, .NET Foundation Pull Request Bot
What is the status of this PR? Can I safely try to use it?
@Havret our team feels the general approach is sound but we have not yet reviewed the details of this PR. Feel free to test it out but I would not recommend call it a perfect indicator of the APIs we'll ship. Put another way, treat dougbu/add.core.II
as a proposed feature branch with more changes expected.
Note the Core Trello and WordPress receivers are currently almost-empty projects. Core Custom, Generic, Instagram, MyGet, VSTS, and Zendesk receivers do not yet exist; neither does anything on the sender side (no Microsoft.AspNetCore.WebHooks.Custom…).
Please let us know if you experience any problems!
For those of you used to the WebHooks 1.0.0 approach:
[GitHubWebHook]
attributes (or whichever receiver you choose)
KuduConstants
(or whichever) and IFormCollection
, JObject
, and XElement
action parameters make it pretty each to grab the information from request bodiesStartup.ConfigureServices(…)
method with services.AddMvcCore().AddAzureAlertWebHooks();
(or whichever)@Havret I'm not sure what you mean. The branch contains a fair number of different Core receivers as well as sample ASP.NET Core MVC applications using them. Could you clarify your question?
@dougbu What's missing is the example how to configure custom receiver which can consume events send by old asp.net publisher. It would be great if you can add something like that. Because lack of documentation I'm having problems with picking up the pieces. Cheers.
Rebased on dougbu/stripe.event.data.154
and removed changes covered in #161. Now includes Stripe support in Core receiver and command-line builds are clean.
:up::date: to reduce number of commits
Is .NET Core 1.0 a possibility?
@JDL440 this PR targets .NET Core 2.0. What drives your 1.0 request?
My service targets 1.0 currently and I'm investigating add webhook subscriptions.
@JDL440 please file a separate issue in this repo so that we can track the idea of re-targeting the new ASP.NET Core support.
Another issue, perhaps filed at https://github.com/aspnet/Home, may help us understand anything blocking migrating your service to .NET Core 2.0. For example, is the documentation at https://docs.microsoft.com/en-us/aspnet/core/migration/1x-to-2x/ insufficient in some way?
5f62336 got this in because it's too big to review. Will address any issues in follow-up PRs.
This approach is more ASP.NET Core-native than #152.
Users write controller actions annotated with (say)
[GitHubWebHookAction]
instead ofWebHookHandler
s. Dispatching between multiple handlers must be done manually though we could add abstract controller base classes which dispatch to handlers in the old way.Those developing new receivers can start from
WebHookReceiver
though the subclasses should also implementIResourceFilter
orIAsyncResourceFilter
. This improves modularity and allows baseWebHook...Filter
s for most needs.