Closed dougbu closed 6 years ago
Rebased on dougbu/infrastructure.updates
and changed questions into proposed answers. Bit easier to review with files?w=1
in the URL.
@HenrikFrystykNielsen I would appreciate your thoughts on the SalesforceSoapWebHookReceiver
and WebHookHandlerContextExtensions
changes. Am I missing something? And, why aren't the unit tests affected? (Should I add more tests?)
Reopening to see if AppVeyor config is working
@HenrikFrystykNielsen there's now nothing in this PR except my suggestions (and a few trailing whitespace removals). Please have a look… I am not confident these changes are correct for the existing receivers.
With thanks for his offline comments, removing @HenrikFrystykNielsen's review request.
:up::date: and ready for @rynowak
78491ef819
Update two quirky-looking bits of code
IsAssignableFrom(...)
use inGetDataOrDefault<T>(...)
nits:
GenericJsonWebHookReceiverTests
WebHookHandlerContextExtensionsTests