aspnet / WebHooks

[Archived] Libraries to create and consume web hooks on ASP.NET Core. Project moved to https://github.com/aspnet/AspLabs
Apache License 2.0
627 stars 439 forks source link

Suggest changes to two quirky-looking bits #161

Closed dougbu closed 6 years ago

dougbu commented 7 years ago

Update two quirky-looking bits of code

nits:

dougbu commented 7 years ago

Rebased on dougbu/infrastructure.updates and changed questions into proposed answers. Bit easier to review with files?w=1 in the URL.

@HenrikFrystykNielsen I would appreciate your thoughts on the SalesforceSoapWebHookReceiver and WebHookHandlerContextExtensions changes. Am I missing something? And, why aren't the unit tests affected? (Should I add more tests?)

dougbu commented 6 years ago

Reopening to see if AppVeyor config is working

dougbu commented 6 years ago

@HenrikFrystykNielsen there's now nothing in this PR except my suggestions (and a few trailing whitespace removals). Please have a look… I am not confident these changes are correct for the existing receivers.

dougbu commented 6 years ago

With thanks for his offline comments, removing @HenrikFrystykNielsen's review request.

dougbu commented 6 years ago

:up::date: and ready for @rynowak

dougbu commented 6 years ago

78491ef819