Closed dougbu closed 6 years ago
@dougbu, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request. Thanks, .NET Foundation Pull Request Bot
Please let me know if I should split the actual PR comments commit (the middle one) into a separate PR. Would be good to get this repo building on our CI soon.
Reopening to test out AppVeyor
@dougbu, Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request. Thanks, .NET Foundation Pull Request Bot
init:
Per your request, pausing my reivew until you've have a chance to update :) #Resolved
Refers to: .appveyor.yml:1 in 3a50b95. [](commit_id = 3a50b95d546aafc36066c290fed9bed66670b571, deletion_comment = False)
:up::date:
Minor :up::date: is just FYI.
@rynowak please dummy-check the few changes in 1f36dd6e1e. StripeVerifyNotificationIdFilter
is about the only class with a significant revision.
8f0a19bfb9
IConfiguration
useIWebHookReceiverConfig
, its implementation and extension methodsasync
only for configuration lookupsPusherVerifySignatureFilter
HttpRequest.IsLocal()
extension methodWebHookAttribute
constructorinternal
and move its doc comments toGeneralWebHookAttribute
WebHookConstants.EventKeyNames
RouteData.TryGetEventName(...)
extension method;WebHookPingResponseFilter
does not need full arrayNote this PR does not close questions @rynowak and I had left unfinished in #153.