Get rid of TODO and `???` comments

[dougbu]

Have filed a few issues to replace TODO items and may file a few more. But, the TODO items need to be cleaned up soon.

The ??? comments are basically questions to reviewers. That got out of hand when #153 grew to almost a hundred commits and almost 250 files. Need to make calls on whatever design decisions aren't yet resolved.

Related points to clean up here:

• Get rid of the IConfiguration.IsTrue(...) extension method. Choices include

  1. just use an existing switch e.g. using only IHostingEnvironment.IsDevelopement() to disable HTTPS checks.
  2. remove a bool knob entirely e.g. switch Stripe to verify request signatures and remove both exiting options, or
  3. map a knob into an IOptions<T> class e.g. use IConfigureOptions<T> to enable passing Stripe test events through to user actions (allow a setting in configuration as well as user Startup code).

  The above choices aren't set in stone for any of the three existing bool configuration settings. Might for example choose to get rid of HTTP support all up.

• Redo the AddSingletonFilter(...) (now AddWebHookSingletonFilter(...) extension methods to simplify the implementation and remove additional extension methods. One option here is to use an IConfigureOptions<MvcOptions, TFilter> implementation instead of the bulk of the current method.

[dougbu]

Note: Only a few of the TODO and ??? items need design 😈

[dougbu]

A few bits addressed as part of other issues. In addition 714a5cd3ec added IMvcBuilder extensions and addressed a TODO.

[dougbu]

Removing needs design label since we've answered the open questions.

[dougbu]

Progress…

• 1585020b74
• e20b745f8a
• fc05979ecc
• 93ea86c77f

[dougbu]

e5b1a66654

[dougbu]

42117af077

[dougbu]

428d143c30

[dougbu]

b4e374bf43

[dougbu]

04d1e1ab0f