aspnet / WebHooks

[Archived] Libraries to create and consume web hooks on ASP.NET Core. Project moved to https://github.com/aspnet/AspLabs

Apache License 2.0

627 stars 439 forks source link

Add tests of ASP.NET Core receivers #180

Closed dougbu closed 6 years ago

dougbu commented 6 years ago

Follow-on work item for #5.

dougbu commented 6 years ago

@mkArtakMSFT cost is arbitrary. Will create a new task for work that doesn't fit in this milestone.

Aim for this milestone is to at least have examples of tests in each area in the product i.e. application model providers, constraints, filters, and maybe attributes. Also need to show the pattern for functional tests of the samples.

mkArtakMSFT commented 6 years ago

Reducing the cost to fit into this milestone. The rest of the work will happen in the future milestones.

dougbu commented 6 years ago

Made some progress on this in Preview 2. Moving rest (including functional tests!) to RC 1.

dougbu commented 6 years ago

Increased cost in hopes we can make more headway in this milestone.

dougbu commented 6 years ago

277 creates the first functional test. Still need to

[ ] add Dropbox functional tests of more success cases, including signature verification
[ ] add functional tests for the remaining samples
[ ] add unit tests of other application model providers, not just WebHookActionModelPropertyProvider
[ ] add unit tests of other core filters, not just WebHookVerifySignatureFilter
[ ] add unit tests of remaining receiver-specific filters
- [ ] DropboxVerifySignatureFilter
- [ ] GitHubVerifySignatureFilter
- [ ] PusherVerifySignatureFilter
- [ ] SalesforceVerifyOrganizationIdFilter
- [ ] SlackVerifyTokenFilter
- [ ] StripeTestEventRequestFilter
- [ ] StripeVerifyNotificationIdFilter
[ ] add unit tests of WebHookFilterProvider, WebHookHttpRequestUtilities, WebHookMetadataProvider, and WebHookRequestReader
[ ] add unit tests of SalesforceNotificationsModelBinderProvider and SalesforceNotificationsModelBinder

WestDiscGolf commented 6 years ago

@dougbu Are all the items in the 1.0.0-rc1 milestone the items which will make the release for when aspnetcore 2.1 is RTM'd? Are there others?

I am assuming this library is on the same release cycle ...

dougbu commented 6 years ago

@WestDiscGolf of the still-open 1.0.0 RC1 issues, #275 should be included in the RC1 release. #180 is about engineering debt and, though I'm working on it now, isn't destined for our 2.1 branches.

Bottom line, the milestone of this issue isn't correct. We'll decide on the correct way to handle it later today.

WestDiscGolf commented 6 years ago

@dougbu thanks for letting me know. Looking forward to the nuget release so I can release the one I've been working on.

Are any of the tests up for grabs? If I can find some time I'd like to contribute :-)

dougbu commented 6 years ago

Are any of the tests up for grabs?

Not at the moment. I may reach out to you (here) if I can't find sample messages for all services. But, coordination at the sub-issue level will get complicated. And, I'm making good progress 😄

WestDiscGolf commented 6 years ago

OK, no worries :-)

dougbu commented 6 years ago

Part 1 of test-only commits in 0eaf1540b8

dougbu commented 6 years ago

Part 2 of test-only commits in d9c0651482. 65dcad481b merged that to dev.

dougbu commented 6 years ago

Closing for RC1. We made some progress, especially on functional tests, in RC1. But, none of the bullets listed earlier are complete enough to check off.

Will file a follow-up item for work in 1.1.0.